cloud-fan commented on code in PR #43385:
URL: https://github.com/apache/spark/pull/43385#discussion_r1364796972
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/InferWindowGroupLimit.scala:
##########
@@ -52,23 +52,32 @@ object InferWindowGroupLimit extends Rule[LogicalPlan] with
PredicateHelper {
if (limits.nonEmpty) Some(limits.min) else None
}
- private def support(
+ /**
+ * All window expressions should use expanding window, so that we can safely
do early stop.
Review Comment:
```suggestion
* All window expressions should use the same expanding window, so that we
can safely do the early stop.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
