Yikf commented on code in PR #43436:
URL: https://github.com/apache/spark/pull/43436#discussion_r1364927001
##########
connector/connect/common/pom.xml:
##########
@@ -47,18 +47,6 @@
<groupId>com.google.protobuf</groupId>
<artifactId>protobuf-java</artifactId>
</dependency>
- <dependency>
Review Comment:
Both connect-server and connect-client have their own independent guava
dependencies : )
I think we should use connect-common shade guava, connect-client and
connect-server shade connect-common to make connect-server and connect-client
use the same guava dependency.
In addition, because connect-common is included in the connect-server shade,
the runnable distribution can also exclude connect-common.
Do you like this current commit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
