srielau commented on code in PR #43438:
URL: https://github.com/apache/spark/pull/43438#discussion_r1365680223
##########
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/CliSuite.scala:
##########
@@ -644,7 +644,8 @@ class CliSuite extends SparkFunSuite {
test("SPARK-37694: delete [jar|file|archive] shall use spark sql processor")
{
runCliWithin(2.minute, errorResponses = Seq("ParseException"))(
- "delete jar dummy.jar;" -> "Syntax error at or near 'jar': missing
'FROM'.(line 1, pos 7)")
+ "delete jar dummy.jar;" ->
+ "Syntax error at or near 'jar': missing 'FROM'. SQLSTATE: 42601(line
1, pos 7)")
Review Comment:
It's not a sentence. But I agree with a space. I need to find where the
(line, pos) is coming from. And prefix the space.
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/MultiDatabaseSuite.scala:
##########
@@ -297,7 +297,7 @@ class MultiDatabaseSuite extends QueryTest with
SQLTestUtils with TestHiveSingle
|)
""".stripMargin)
}.getMessage
- assert(message.contains("`t:a` is not a valid name for
tables/databases. " +
+ assert(message.contains("`t:a` is not a valid name for tables/schemas.
" +
Review Comment:
**Hehe** Yes, I had trouble overcoming my inner pig.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
