zhaomin1423 commented on PR #43439: URL: https://github.com/apache/spark/pull/43439#issuecomment-1771459952
> The change looks good, can I also ask if you could add a test for it, e.g. following [this test example](https://github.com/netty/netty/blob/main/buffer/src/test/java/io/netty5/buffer/tests/BufferCleanerTest.java#L55)? Sorry, This example compares memory usage because of the allocated off-heap memory, it seems difficult for us to compare memory usage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
