HyukjinKwon commented on code in PR #43161: URL: https://github.com/apache/spark/pull/43161#discussion_r1366445196
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala: ########## @@ -175,30 +176,7 @@ abstract class TreeNode[BaseType <: TreeNode[BaseType]] lazy val height: Int = children.map(_.height).reduceOption(_ max _).getOrElse(0) + 1 - // Copied from Scala 2.13.1 - // github.com/scala/scala/blob/v2.13.1/src/library/scala/util/hashing/MurmurHash3.scala#L56-L73 - // to prevent the issue https://github.com/scala/bug/issues/10495 - // TODO(SPARK-30848): Remove this once we drop Scala 2.12. Review Comment: You can use https://issues.apache.org/jira/browse/SPARK-30848 JIRA :-). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
