ukby1234 commented on code in PR #42296: URL: https://github.com/apache/spark/pull/42296#discussion_r1366453322
########## core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala: ########## @@ -111,6 +111,14 @@ final class ShuffleBlockFetcherIterator( // nodes, rather than blocking on reading output from one node. private val targetRemoteRequestSize = math.max(maxBytesInFlight / 5, 1L) + private val isShuffleMigrationEnabled = + SparkEnv.get.conf.get(config.DECOMMISSION_ENABLED) && + SparkEnv.get.conf.get(config.STORAGE_DECOMMISSION_ENABLED) && + SparkEnv.get.conf.get(config.STORAGE_DECOMMISSION_SHUFFLE_BLOCKS_ENABLED) + + private val shouldPerformShuffleLocationRefresh = Review Comment: what about make this one of the constructor argument? One of the benefit is that you don't need to write tests with `TestUtils.withConf` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
