HeartSaVioR opened a new pull request, #43483:
URL: https://github.com/apache/spark/pull/43483

   ### What changes were proposed in this pull request?
   
   Credit to @anish-db for the initial investigation and the fix.
   
   This PR proposes to remove @abstractmethod annotation from `onQueryIdle` in 
PySpark StreamingQueryListener.
   
   The function `onQueryIdle` was added with the annotation @abstractmethod, 
which does not pick up default implementation and enforces users to implement 
the new method. This breaks all existing streaming query listener 
implementations and enforces them to add the dummy function implementation at 
least.
   
   This PR re-allows existing implementations to work properly without 
explicitly adding a new function `onQueryIdle`.
   
   ### Why are the changes needed?
   
   We broke backward compatibility in 
[SPARK-43183](https://issues.apache.org/jira/browse/SPARK-43183) and we want to 
fix it.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Modified tests. Now tests are verifying two different implementations 
covering old interface vs new interface.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to