zhengruifeng commented on code in PR #43465:
URL: https://github.com/apache/spark/pull/43465#discussion_r1369453264
##########
python/pyspark/sql/connect/plan.py:
##########
@@ -2214,7 +2214,9 @@ def __init__(
self._input_grouping_cols = input_grouping_cols
self._other_grouping_cols = other_grouping_cols
self._other = cast(LogicalPlan, other)
- self._func = function._build_common_inline_user_defined_function(*cols)
+ # The function takes entire DataFrame as inputs, no need to do
+ # column binding (no input columns).
+ self._func = function._build_common_inline_user_defined_function()
Review Comment:
it seems this field is not used in connect
https://github.com/apache/spark/blob/48e207f4a2192d474f2c0f141b984ef0c36a78c3/connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala#L694-L723
cc @xinrong-meng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
