LuciferYang commented on code in PR #43522:
URL: https://github.com/apache/spark/pull/43522#discussion_r1371208131
##########
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java:
##########
@@ -99,7 +99,7 @@ public class SparkLauncher extends
AbstractLauncher<SparkLauncher> {
* @deprecated use `CHILD_CONNECTION_TIMEOUT`
* @since 1.6.0
*/
- @Deprecated
+ @Deprecated(since = "3.2.0")
Review Comment:
Which is better, `since = "3.2.0"` or `since = "3.2.0"` ? The latter is
also used in Spark, such as
https://github.com/apache/spark/blob/093b7e1846b43273538e9b50898685478ceb6089/streaming/src/main/scala/org/apache/spark/streaming/api/java/JavaStreamingContext.scala#L59-L61
##########
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java:
##########
@@ -99,7 +99,7 @@ public class SparkLauncher extends
AbstractLauncher<SparkLauncher> {
* @deprecated use `CHILD_CONNECTION_TIMEOUT`
* @since 1.6.0
*/
- @Deprecated
+ @Deprecated(since = "3.2.0")
Review Comment:
Which is better, `since = "3.2.0"` or `since = "Spark 3.2.0"` ? The latter
is also used in Spark, such as
https://github.com/apache/spark/blob/093b7e1846b43273538e9b50898685478ceb6089/streaming/src/main/scala/org/apache/spark/streaming/api/java/JavaStreamingContext.scala#L59-L61
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
