HyukjinKwon commented on code in PR #43511:
URL: https://github.com/apache/spark/pull/43511#discussion_r1372548032
##########
sql/core/src/test/scala/org/apache/spark/sql/connector/GroupBasedDeleteFromTableSuite.scala:
##########
@@ -96,27 +96,14 @@ class GroupBasedDeleteFromTableSuite extends
DeleteFromTableSuiteBase {
}
}
- test("delete runtime group filtering (DPP enabled)") {
- withSQLConf(SQLConf.DYNAMIC_PARTITION_PRUNING_ENABLED.key -> "true") {
- checkDeleteRuntimeGroupFiltering()
- }
- }
-
- test("delete runtime group filtering (DPP disabled)") {
- withSQLConf(SQLConf.DYNAMIC_PARTITION_PRUNING_ENABLED.key -> "false") {
- checkDeleteRuntimeGroupFiltering()
- }
- }
-
- test("delete runtime group filtering (AQE enabled)") {
- withSQLConf(SQLConf.ADAPTIVE_EXECUTION_ENABLED.key -> "true") {
- checkDeleteRuntimeGroupFiltering()
- }
- }
-
- test("delete runtime group filtering (AQE disabled)") {
- withSQLConf(SQLConf.ADAPTIVE_EXECUTION_ENABLED.key -> "false") {
- checkDeleteRuntimeGroupFiltering()
+ test("delete runtime group filtering") {
Review Comment:
When the test fails, we won't know if AQE or DPP is enabled or disabled?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
