Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6406#discussion_r31013556
  
    --- Diff: 
core/src/main/scala/org/apache/spark/status/api/v1/SimpleDateParam.scala ---
    @@ -42,14 +42,16 @@ private[v1] class SimpleDateParam(val originalValue: 
String) {
     
     private[v1] object SimpleDateParam {
     
    -  val formats: Seq[SimpleDateFormat] = {
    +  // `SimpleDateFormat` is not thread-safe
    +  val formats = new ThreadLocal[Seq[SimpleDateFormat]]() {
    --- End diff --
    
    I just feel using `ThreadLocal` is easy and minimizes the changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to