MaxGekk commented on code in PR #43481:
URL: https://github.com/apache/spark/pull/43481#discussion_r1373024937
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala:
##########
@@ -601,9 +616,9 @@ class CollectionExpressionsSuite extends SparkFunSuite with
ExpressionEvalHelper
checkEvaluation(Slice(a0, Literal(4), Literal(10)), Seq(4, 5, 6))
checkEvaluation(Slice(a0, Literal(-1), Literal(2)), Seq(6))
checkExceptionInExpression[RuntimeException](Slice(a0, Literal(1),
Literal(-1)),
Review Comment:
Could you use `checkErrorInExpression` to check the error class and its
parameterers.
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala:
##########
@@ -601,9 +616,9 @@ class CollectionExpressionsSuite extends SparkFunSuite with
ExpressionEvalHelper
checkEvaluation(Slice(a0, Literal(4), Literal(10)), Seq(4, 5, 6))
checkEvaluation(Slice(a0, Literal(-1), Literal(2)), Seq(6))
checkExceptionInExpression[RuntimeException](Slice(a0, Literal(1),
Literal(-1)),
Review Comment:
Could you use `checkErrorInExpression` to check the error class and its
parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
