beliefer commented on code in PR #41860:
URL: https://github.com/apache/spark/pull/41860#discussion_r1374028545
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/InjectRuntimeFilter.scala:
##########
@@ -322,9 +332,6 @@ object InjectRuntimeFilter extends Rule[LogicalPlan] with
PredicateHelper with J
isSimpleExpression(l) && isSimpleExpression(r)) {
val oldLeft = newLeft
val oldRight = newRight
- // Check if the current join is a shuffle join or a broadcast join
that
- // has a shuffle below it
- val hasShuffle = isProbablyShuffleJoin(left, right, hint)
Review Comment:
Yes. I agree that is a tradeoff. If we put it outside the loop, any join
lead to call `isProbablyShuffleJoin`.
I think we'd better not change it If we don't have a more reasonable reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
