beliefer commented on code in PR #37588:
URL: https://github.com/apache/spark/pull/37588#discussion_r1375220594
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala:
##########
@@ -884,19 +884,39 @@ object ShowTables {
}
/**
- * The logical plan of the SHOW TABLE EXTENDED command.
+ * The logical plan of the SHOW TABLE EXTENDED (without PARTITION) command.
*/
-case class ShowTableExtended(
+case class ShowTablesExtended(
namespace: LogicalPlan,
pattern: String,
- partitionSpec: Option[PartitionSpec],
- override val output: Seq[Attribute] = ShowTableExtended.getOutputAttrs)
extends UnaryCommand {
+ override val output: Seq[Attribute] = ShowTablesExtended.getOutputAttrs)
Review Comment:
It seems we can keep the line as
`override val output: Seq[Attribute] = ShowTableExtended.getOutputAttrs)
extends UnaryCommand {`
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Implicits.scala:
##########
@@ -30,6 +30,7 @@ import org.apache.spark.sql.util.CaseInsensitiveStringMap
object DataSourceV2Implicits {
implicit class TableHelper(table: Table) {
+
Review Comment:
No need.
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala:
##########
@@ -4055,19 +4055,28 @@ class AstBuilder extends DataTypeAstBuilder with
SQLConfHelper with Logging {
}
/**
- * Create a [[ShowTableExtended]] command.
+ * Create a [[ShowTablesExtended]] or [[ShowTablePartition]] command.
*/
override def visitShowTableExtended(
Review Comment:
Because we change `ShowTableExtended` to `ShowTablesExtended`, shall we
update the name in g4 ?
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala:
##########
@@ -2133,12 +2133,6 @@ private[sql] object QueryCompilationErrors extends
QueryErrorsBase with Compilat
"inputTypesLen" -> bound.inputTypes().length.toString))
}
- def commandUnsupportedInV2TableError(name: String): Throwable = {
- new AnalysisException(
- errorClass = "_LEGACY_ERROR_TEMP_1200",
- messageParameters = Map("name" -> name))
- }
Review Comment:
We can remove the error class too.
##########
sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala:
##########
@@ -240,19 +240,33 @@ class ResolveSessionCatalog(val catalogManager:
CatalogManager)
case ShowTables(DatabaseInSessionCatalog(db), pattern, output) if
conf.useV1Command =>
ShowTablesCommand(Some(db), pattern, output)
- case ShowTableExtended(
+ case ShowTablesExtended(
DatabaseInSessionCatalog(db),
pattern,
- partitionSpec @ (None | Some(UnresolvedPartitionSpec(_, _))),
output) =>
val newOutput = if
(conf.getConf(SQLConf.LEGACY_KEEP_COMMAND_OUTPUT_SCHEMA)) {
assert(output.length == 4)
output.head.withName("database") +: output.tail
} else {
output
}
- val tablePartitionSpec =
partitionSpec.map(_.asInstanceOf[UnresolvedPartitionSpec].spec)
- ShowTablesCommand(Some(db), Some(pattern), newOutput, true,
tablePartitionSpec)
+ ShowTablesCommand(Some(db), Some(pattern), newOutput, isExtended = true)
+
+ case ShowTablePartition(
+ ResolvedTable(catalog, _, table: V1Table, _),
+ partitionSpec,
+ output) if isSessionCatalog(catalog) =>
+ val newOutput = if
(conf.getConf(SQLConf.LEGACY_KEEP_COMMAND_OUTPUT_SCHEMA)) {
+ assert(output.length == 4)
Review Comment:
I think this assert is no need.
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala:
##########
@@ -2471,7 +2465,7 @@ private[sql] object QueryCompilationErrors extends
QueryErrorsBase with Compilat
errorClass = "_LEGACY_ERROR_TEMP_1231",
messageParameters = Map(
"key" -> key,
- "tblName" -> tblName))
+ "tblName" -> toSQLId(tblName)))
Review Comment:
We can change it if we rename the error class.
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala:
##########
@@ -2483,7 +2477,7 @@ private[sql] object QueryCompilationErrors extends
QueryErrorsBase with Compilat
messageParameters = Map(
"specKeys" -> specKeys,
"partitionColumnNames" -> partitionColumnNames.mkString(", "),
- "tableName" -> tableName))
+ "tableName" -> toSQLId(tableName)))
Review Comment:
ditto
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala:
##########
@@ -2471,7 +2465,7 @@ private[sql] object QueryCompilationErrors extends
QueryErrorsBase with Compilat
errorClass = "_LEGACY_ERROR_TEMP_1231",
messageParameters = Map(
"key" -> key,
- "tblName" -> tblName))
+ "tblName" -> toSQLId(tblName)))
Review Comment:
It seems this change is not related to PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
