StardustDL commented on code in PR #42125: URL: https://github.com/apache/spark/pull/42125#discussion_r1375677739
########## dev/python-detect-breaking-changes.py: ########## @@ -0,0 +1,182 @@ +#!/usr/bin/env python3 + +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +# Original repository: https://github.com/StardustDL/aexpy +# Copyright 2022 StardustDL <[email protected]> +# + +# Usage: compare current code base with a commit or branch +# python dev/python-detect-breaking-changes.py a540995345bc935db3b8ccf5cb94cb7caabc4847 (branch name or commit id) Review Comment: done, added the shebang `#!/usr/bin/env python3` to the script. `python dev/python-detect-breaking-changes.py branch-3.4` fails probably because the branch has not been fetched into local git database. Since aexpy needs to checkout the target branch to get the source code, it depends on `git worktree` command (similar to `git checkout`). I have added `git fetch` command before `git worktree` to solve this, and update error message for this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
