heyihong commented on PR #43586: URL: https://github.com/apache/spark/pull/43586#issuecomment-1785765470
> @heyihong the cat is already out of bag. I don't want to put it back in. I don't have a strong opinion on either but exposing collectResult but not exposing the return type [SparkResult](https://github.com/apache/spark/blob/master/connector/connect/common/src/main/scala/org/apache/spark/sql/connect/client/SparkResult.scala#L36) be private[sql] seems inconsistent to me since SparkResult is private[sql]. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
