MaxGekk commented on code in PR #43334:
URL: https://github.com/apache/spark/pull/43334#discussion_r1377416076
##########
sql/api/src/main/scala/org/apache/spark/sql/catalyst/trees/QueryContexts.scala:
##########
@@ -128,6 +129,45 @@ case class SQLQueryContext(
sqlText.isDefined && originStartIndex.isDefined &&
originStopIndex.isDefined &&
originStartIndex.get >= 0 && originStopIndex.get < sqlText.get.length &&
originStartIndex.get <= originStopIndex.get
+ }
+
+ override def callSite: String = throw new UnsupportedOperationException
+}
+
+case class DatasetQueryContext(
+ override val fragment: String,
+ override val callSite: String) extends QueryContext {
+ override val contextType = QueryContextType.Dataset
+
+ override def objectType: String = throw new UnsupportedOperationException
+ override def objectName: String = throw new UnsupportedOperationException
+ override def startIndex: Int = throw new UnsupportedOperationException
+ override def stopIndex: Int = throw new UnsupportedOperationException
+
+ override lazy val summary: String = {
+ val builder = new StringBuilder
+ builder ++= "== Dataset ==\n"
+ builder ++= "\""
+
+ builder ++= fragment
+ builder ++= "\""
+ builder ++= " was called from "
Review Comment:
Not sure about this. Now it looks:
```
== Dataset ==
"col" was called from
org.apache.spark.sql.DatasetSuite.$anonfun$new$621(DatasetSuite.scala:2673)
```
but what you propose:
```
== Dataset ==
"col" was called from
org.apache.spark.sql.DatasetSuite.$anonfun$new$621(DatasetSuite.scala:2673)
```
@cloud-fan Are you sure?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
