cloud-fan commented on code in PR #43614:
URL: https://github.com/apache/spark/pull/43614#discussion_r1378488137
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/InlineCTE.scala:
##########
@@ -120,6 +120,30 @@ case class InlineCTE(alwaysInline: Boolean = false)
extends Rule[LogicalPlan] {
}
}
}
+ // If a CTE ref count is 0, the other CTE that is referencing it should
also have
Review Comment:
I'm a bit concerned about changing the ref count directly. I think the ref
count is correct, the problem is in `CheckAnalysis` when we decide which CTE
relations need to be checked ahead. The current condition is simply `refCount
== 0`, but we should also check CTE relations referenced by CTE relations that
has 0 refCount.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
