LuciferYang commented on code in PR #43578:
URL: https://github.com/apache/spark/pull/43578#discussion_r1378576854
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/JoinEstimation.scala:
##########
@@ -206,13 +206,12 @@ case class JoinEstimation(join: Join) extends Logging {
case _ =>
computeByNdv(leftKey, rightKey, newMin, newMax)
}
- keyStatsAfterJoin += (
- // Histograms are propagated as unchanged. During future estimation,
they should be
- // truncated by the updated max/min. In this way, only pointers of
the histograms are
- // propagated and thus reduce memory consumption.
- leftKey -> joinStat.copy(histogram = leftKeyStat.histogram),
- rightKey -> joinStat.copy(histogram = rightKeyStat.histogram)
- )
+ // Histograms are propagated as unchanged. During future estimation,
they should be
Review Comment:
Is it possible not to modify `keyStatsAfterJoin +=` and the relative
position of the comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
