viirya commented on code in PR #43638:
URL: https://github.com/apache/spark/pull/43638#discussion_r1380703869
##########
core/src/test/scala/org/apache/spark/deploy/history/EventLogFileWritersSuite.scala:
##########
@@ -66,7 +66,7 @@ abstract class EventLogFileWritersSuite extends SparkFunSuite
with LocalSparkCon
conf.set(EVENT_LOG_DIR, testDir.toString)
// default config
- buildWriterAndVerify(conf, classOf[SingleEventLogFileWriter])
+ buildWriterAndVerify(conf, classOf[RollingEventLogFilesWriter])
conf.set(EVENT_LOG_ENABLE_ROLLING, true)
Review Comment:
Is it redundant then?
```suggestion
conf.set(EVENT_LOG_ENABLE_ROLLING, true)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
