GitHub user liancheng opened a pull request:

    https://github.com/apache/spark/pull/6414

    [SQL] [Minor] Tests the data type conversion code paths

    In `SimpleTextRelation`, we specified `needsConversion` to `true`, 
indicating that values produced by this testing relation should be of Scala 
types, and need to be converted to Catalyst types when necessary. However, we 
also used `Cast` to convert strings to expected data types. And `Cast` always 
produces values of Catalyst types, thus no conversion is done at all. This PR 
makes `SimpleTextRelation` produce Scala values so that data conversion code 
paths can be properly tested.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/liancheng/spark 
hadoop-fs-relation-conversion-test

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/6414.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6414
    
----
commit 9968fba9979287aaa1f141ba18bfb9d4c116a3b3
Author: Cheng Lian <[email protected]>
Date:   2015-05-26T15:44:39Z

    Tests the data type conversion code paths

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to