abellina commented on code in PR #43627:
URL: https://github.com/apache/spark/pull/43627#discussion_r1383413842


##########
core/src/main/scala/org/apache/spark/SparkEnv.scala:
##########
@@ -402,7 +405,7 @@ object SparkEnv extends Logging {
             None
           }, blockManagerInfo,
           mapOutputTracker.asInstanceOf[MapOutputTrackerMaster],
-          shuffleManager,
+          shuffleBlockGetterFn,

Review Comment:
   I see this being an issue in tests where the `SparkEnv` would not be set, so 
now I'd have to make sure that the env is set and cleared in the tests. That 
said, if you feel strongly about this, I can look at this more.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to