allisonwang-db commented on code in PR #43682:
URL: https://github.com/apache/spark/pull/43682#discussion_r1384255664
##########
python/pyspark/worker.py:
##########
@@ -1057,6 +1059,9 @@ def mapper(_, it):
yield from eval(*[a[o] for o in args_kwargs_offsets])
if terminate is not None:
yield from terminate()
+ except StopIteration:
+ if terminate is not None:
+ yield from terminate()
Review Comment:
Ah the exception thrown in eval will be caught by this
```
except Exception as e:
raise PySparkRuntimeError(
error_class="UDTF_EXEC_ERROR",
```
I wonder if we should just move the whole try ... except ... block to this
mapper function instead of checking this for every single input row.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
