cloud-fan commented on code in PR #42577: URL: https://github.com/apache/spark/pull/42577#discussion_r1384616988
########## sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/CreateTableClusterBySuite.scala: ########## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.execution.command.v1 + +import org.apache.spark.sql.AnalysisException +import org.apache.spark.sql.catalyst.TableIdentifier +import org.apache.spark.sql.catalyst.analysis.UnresolvedAttribute +import org.apache.spark.sql.catalyst.catalog.ClusterBySpec +import org.apache.spark.sql.connector.catalog.CatalogManager.SESSION_CATALOG_NAME +import org.apache.spark.sql.execution.command + +/** + * This base suite contains unified tests for the `CREATE TABLE ... CLUSTER BY` command that + * checks V1 table catalogs. The tests that cannot run for all V1 catalogs are located in more + * specific test suites: + * + * - V1 In-Memory catalog: `org.apache.spark.sql.execution.command.v1.CreateTableClusterBySuite` + * - V1 Hive External catalog: + * `org.apache.spark.sql.hive.execution.command.CreateTableClusterBySuite` + */ +trait CreateTableClusterBySuiteBase extends command.CreateTableClusterBySuiteBase + with command.TestsV1AndV2Commands { + override def validateClusterBy( + tableIdent: TableIdentifier, clusteringColumns: Seq[String]): Unit = { + val catalog = spark.sessionState.catalog + val table = catalog.getTableMetadata(tableIdent) + assert(table.clusterBySpec === + Some(ClusterBySpec(clusteringColumns.map(UnresolvedAttribute(_))))) + } +} + +/** + * The class contains tests for the `CREATE TABLE ... CLUSTER BY` command to check V1 In-Memory + * table catalog. + */ +class CreateTableClusterBySuite extends CreateTableClusterBySuiteBase + with CommandSuiteBase { + override def commandVersion: String = super[CreateTableClusterBySuiteBase].commandVersion + + test("clustering columns not defined in schema") { + withNamespaceAndTable("ns", "table") { tbl => + checkError( + exception = intercept[AnalysisException]( + sql(s"CREATE TABLE $tbl (id bigint, data string) $defaultUsing CLUSTER BY (unknown)")), + errorClass = "COLUMN_NOT_DEFINED_IN_TABLE", Review Comment: oh I see https://github.com/apache/spark/pull/42577/files#diff-d96524deae4f3cbf30881f842ab6091aea1de9d3e5c6810f4f35d3dc697dd3d3R58 It's better if we can unify the error between v1 and v2. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
