peter-toth commented on code in PR #41677: URL: https://github.com/apache/spark/pull/41677#discussion_r1384931717
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/EquivalentExpressions.scala: ########## @@ -30,211 +30,382 @@ import org.apache.spark.util.Utils * This class is used to compute equality of (sub)expression trees. Expressions can be added * to this class and they subsequently query for expression equality. Expression trees are * considered equal if for the same input(s), the same result is produced. + * + * Please note that `EquivalentExpressions` is mainly used in subexpression elimination where common + * non-leaf expression subtrees are calculated, but there there is one special use case in + * `PhysicalAggregation` where `EquivalentExpressions` is used as a mutable set of non-deterministic Review Comment: Yeah, this is not right. I should have written `mutable set of deterministic expressions` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
