LuciferYang commented on code in PR #43642:
URL: https://github.com/apache/spark/pull/43642#discussion_r1385077519
##########
project/SparkBuild.scala:
##########
@@ -254,7 +254,8 @@ object SparkBuild extends PomBuild {
// SPARK-45627 `enum`, `export` and `given` will become keywords in
Scala 3,
// so they are prohibited from being used as variable names in Scala
2.13 to
// reduce the cost of migration in subsequent versions.
- "-Wconf:cat=deprecation&msg=it will become a keyword in Scala 3:e"
+ "-Wconf:cat=deprecation&msg=it will become a keyword in Scala 3:e",
+ "-Wconf:cat=deprecation&msg=Passing an explicit array value to a Scala
varargs method is deprecated:e"
Review Comment:
> Shall we keep it to avoid other folks adding the case again?
This will cause some memory consumption and performance difference in
collection copy, so it is indeed a problem. However, I prefer to wait for a
while and see if the related cases increase rapidly again. If so, we can clean
them up again and make it a stricter compile check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
