MaxGekk commented on code in PR #43702:
URL: https://github.com/apache/spark/pull/43702#discussion_r1385535391
##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/client/SparkConnectClientSuite.scala:
##########
@@ -210,19 +209,15 @@ class SparkConnectClientSuite extends ConnectFunSuite
with BeforeAndAfterEach {
}
for ((name, constructor) <- GrpcExceptionConverter.errorFactory) {
- test(s"error framework parameters - ${name}") {
+ test(s"error framework parameters - $name") {
val testParams = GrpcExceptionConverter.ErrorParams(
- message = "test message",
+ message = "Found duplicate keys `abc`",
cause = None,
- errorClass = Some("test error class"),
- messageParameters = Map("key" -> "value"),
+ errorClass = Some("DUPLICATE_KEY"),
Review Comment:
After the changes, the error class must be a valid one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
