beliefer commented on code in PR #43694:
URL: https://github.com/apache/spark/pull/43694#discussion_r1385914250
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala:
##########
@@ -823,17 +826,19 @@ case class Cast(
buildCast[Boolean](_, b => if (b) 1.toShort else 0.toShort)
case DateType =>
buildCast[Int](_, d => null)
- case TimestampType if ansiEnabled =>
+ case TimestampType =>
buildCast[Long](_, t => {
val longValue = timestampToLong(t)
if (longValue == longValue.toShort) {
longValue.toShort
} else {
- throw QueryExecutionErrors.castingCauseOverflowError(t, from,
ShortType)
+ if (ansiEnabled) {
+ throw QueryExecutionErrors.castingCauseOverflowError(t, from,
ShortType)
+ } else {
+ null
+ }
Review Comment:
Shall we extract the logic as a common method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
