dtenedor commented on code in PR #43707:
URL: https://github.com/apache/spark/pull/43707#discussion_r1387033411
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/types/PhysicalDataType.scala:
##########
@@ -326,6 +327,17 @@ case class PhysicalStructType(fields: Array[StructField])
extends PhysicalDataTy
}
}
+class PhysicalVariantType extends PhysicalDataType {
Review Comment:
can we add a comment for this?
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/variant/variantExpressions.scala:
##########
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.catalyst.expressions.variant
+
+import org.apache.spark.sql.catalyst.expressions._
+import org.apache.spark.sql.catalyst.expressions.codegen.CodegenFallback
+import org.apache.spark.sql.types._
+import org.apache.spark.unsafe.types._
+
+// scalastyle:off line.size.limit
+@ExpressionDescription(
+ usage = "_FUNC_(jsonStr) - Parse a JSON string as an Variant value. Throw an
exception when the string is not valid JSON value.",
+ examples =
+ """
+ Examples:
+ """,
+ since = "3.4.0",
+ group = "variant_funcs"
+)
+// scalastyle:on line.size.limit
+case class ParseJson(child: Expression) extends UnaryExpression
+ with NullIntolerant with ExpectsInputTypes with CodegenFallback {
+ override def inputTypes: Seq[AbstractDataType] = StringType :: Nil
+
+ override def dataType: DataType = VariantType
+
+ override def nullable: Boolean = false
+
+ override def prettyName: String = "parse_json"
+
+ protected override def nullSafeEval(input: Any): Any = {
+ // A dummy implementation: the value is the raw bytes of the input string.
This is not the final
+ // implementation, but only intended for debugging.
+ new VariantVal(input.asInstanceOf[UTF8String].toString.getBytes, Array())
Review Comment:
we should probably implement the `checkInputDataTypes` method to enforce
that the `input` is actually a `UTF8String` before we reach this point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
