LuciferYang commented on PR #43709: URL: https://github.com/apache/spark/pull/43709#issuecomment-1803085434
> There are also some places where `Collections.unmodifiable` is used, such as > > https://github.com/apache/spark/blob/bfcd2c47742d69632584f6bb3cf08a8bc3ca8c8c/sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/CatalogV2Util.scala#L85-L102 > > But I don't think the new API can make them look simpler, so I didn't change them in this pr @dongjoon-hyun There are three other similar places here, and I think both `Collections.unmodifiableMap` and `Map.copyOf` can be used, and `Map.copyOf` will trigger a collection copy, so no changes were made in this pr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
