dongjoon-hyun commented on code in PR #43717:
URL: https://github.com/apache/spark/pull/43717#discussion_r1387438134
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/maskExpressions.scala:
##########
@@ -197,7 +197,7 @@ case class Mask(
*/
override def eval(input: InternalRow): Any = {
Mask.transformInput(
- children(0).eval(input),
+ children.head.eval(input),
Review Comment:
In this case, the old one is more consistent to the next lines.
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/maskExpressions.scala:
##########
@@ -237,7 +237,7 @@ case class Mask(
ctx: CodegenContext,
ev: ExprCode,
f: (String, String, String, String, String) => String): ExprCode = {
- val firstGen = children(0).genCode(ctx)
+ val firstGen = children.head.genCode(ctx)
Review Comment:
ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
