beliefer commented on code in PR #43695:
URL: https://github.com/apache/spark/pull/43695#discussion_r1387790724


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -4531,6 +4531,14 @@ object SQLConf {
       .booleanConf
       .createWithDefault(false)
 
+  val EXTRA_ORIGIN_TRACES = buildConf("spark.sql.extraOriginTraces")
+    .doc("The number of additional non-Spark SQL traces in the captured 
DataFrame context. " +
+      "When it is set to 0, captured one Spark traces and a followed non-Spark 
trace.")
+    .version("4.0.0")
+    .intConf
+    .checkValue(_ >= 0, "The number of extra thread traces must be 
non-negative.")

Review Comment:
   I feel that:
   default 1: this is consistent with before.
   The number of `extraOriginTraces`  should consistent with the number of 
non-Spark trace size.
   Then we use `> 0` as the constraint.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to