zhengruifeng commented on code in PR #43739:
URL: https://github.com/apache/spark/pull/43739#discussion_r1388656184


##########
mllib/src/test/scala/org/apache/spark/ml/FunctionsSuite.scala:
##########
@@ -101,4 +102,41 @@ class FunctionsSuite extends MLTest {
     val resultVec3 = 
df3.select(array_to_vector(col("c1"))).collect()(0)(0).asInstanceOf[Vector]
     assert(resultVec3 === Vectors.dense(Array(1.0, 2.0)))
   }
+
+  test("SPARK-45859: 'functions$' should not be affected by a broken class 
loader") {
+    quietly {
+      // Only one SparkContext should be running in this JVM (see SPARK-2243)
+      sc.stop()

Review Comment:
   good point, we'd better close `sc` in this UT, in case contributors add new 
UTs after this one and tested with non-expected `sc`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to