ueshin commented on code in PR #43690:
URL: https://github.com/apache/spark/pull/43690#discussion_r1388725778
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/execution/ExecuteThreadRunner.scala:
##########
@@ -162,6 +162,18 @@ private[connect] class ExecuteThreadRunner(executeHolder:
ExecuteHolder) extends
s"${executeHolder.request.getPlan.getOpTypeCase} not supported.")
}
+ if (executeHolder.observations.nonEmpty) {
+ val observedMetrics = executeHolder.observations.map { case (name,
observation) =>
Review Comment:
The observed metrics sent in `SparkConnectPlanExecution.handlePlan` is now
for the case of `input.isStreaming || executeHolderOpt.isEmpty`; otherwise,
they will be sent here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
