HyukjinKwon commented on code in PR #43741:
URL: https://github.com/apache/spark/pull/43741#discussion_r1389039188
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -1217,7 +1217,8 @@ class SparkConnectPlanner(
rel.getReadTypeCase match {
case proto.Read.ReadTypeCase.NAMED_TABLE =>
val multipartIdentifier =
-
CatalystSqlParser.parseMultipartIdentifier(rel.getNamedTable.getUnparsedIdentifier)
+ session.sessionState.sqlParser
+ .parseMultipartIdentifier(rel.getNamedTable.getUnparsedIdentifier)
Review Comment:
I think we can add a test under `SparkConnectPlannerSuite` that uses a
cloned `SparkSession` that defines a separate parser with
`SparkSession.withExtensions` that overrides `parseMultipartIdentifier` which
throws an exception (see `MyParser` at `SparkSessionExtensionSuite`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
