juliuszsompolski commented on code in PR #43745:
URL: https://github.com/apache/spark/pull/43745#discussion_r1389160092
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/SparkSession.scala:
##########
@@ -251,7 +251,7 @@ class SparkSession private[sql] (
.addAllPosArguments(args.map(lit(_).expr).toImmutableArraySeq.asJava)))
val plan = proto.Plan.newBuilder().setCommand(cmd)
// .toBuffer forces that the iterator is consumed and closed
- val responseSeq = client.execute(plan.build()).toBuffer.toSeq
+ val responseSeq = client.execute(plan.build()).toSeq
Review Comment:
`.toSeq` returns a lazy stream, which is not consumed (and ReleaseExecute
from ExecutePlanResponseReattachableIterator doesn't get called) unless someone
iterates through it entirely.
Before, there were some places doing `.foreach(_ => Unit)` for the same
purpose. I found `.toBuffer` to be more concise, so changes these places to
`.toBuffer`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
