LuciferYang commented on code in PR #43745:
URL: https://github.com/apache/spark/pull/43745#discussion_r1389715070
##########
connector/connect/common/src/main/scala/org/apache/spark/sql/connect/client/ExecutePlanResponseReattachableIterator.scala:
##########
@@ -324,3 +324,13 @@ class ExecutePlanResponseReattachableIterator(
private def retry[T](fn: => T): T =
GrpcRetryHandler.retry(retryPolicy)(fn)
}
+
+private[connect] object ExecutePlanResponseReattachableIterator {
Review Comment:
I placed the helper method on the companion object of
`ExecutePlanResponseReattachableIterator ` and set its scope to
`private[connect]`
##########
connector/connect/common/src/main/scala/org/apache/spark/sql/connect/client/ExecutePlanResponseReattachableIterator.scala:
##########
@@ -324,3 +324,13 @@ class ExecutePlanResponseReattachableIterator(
private def retry[T](fn: => T): T =
GrpcRetryHandler.retry(retryPolicy)(fn)
}
+
+private[connect] object ExecutePlanResponseReattachableIterator {
Review Comment:
I placed the helper function on the companion object of
`ExecutePlanResponseReattachableIterator ` and set its scope to
`private[connect]`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
