beliefer commented on code in PR #43707: URL: https://github.com/apache/spark/pull/43707#discussion_r1390566930
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/variant/variantExpressions.scala: ########## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalyst.expressions.variant + +import org.apache.spark.sql.catalyst.expressions._ +import org.apache.spark.sql.catalyst.expressions.codegen.CodegenFallback +import org.apache.spark.sql.types._ +import org.apache.spark.unsafe.types._ + +// scalastyle:off line.size.limit Review Comment: Based on the discussion at https://github.com/apache/spark/pull/43707#discussion_r1390064666. Please add note to describe the fake example and add todo. ########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/types/PhysicalDataType.scala: ########## @@ -327,6 +328,17 @@ case class PhysicalStructType(fields: Array[StructField]) extends PhysicalDataTy } } +class PhysicalVariantType extends PhysicalDataType { + private[sql] type InternalType = VariantVal + @transient private[sql] lazy val tag = typeTag[InternalType] + + override private[sql] def ordering = + throw QueryExecutionErrors.orderedOperationUnsupportedByDataTypeError( + "PhysicalVariantType") Review Comment: Shall we supports sort in future? ########## sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala: ########## @@ -1564,6 +1564,12 @@ private[sql] object QueryCompilationErrors extends QueryErrorsBase with Compilat messageParameters = Map.empty) } + def cannotSaveVariantIntoExternalStorageError(): Throwable = { + new AnalysisException( + errorClass = "CANNOT_SAVE_VARIANT", Review Comment: cc @MaxGekk ########## sql/core/src/test/scala/org/apache/spark/sql/VariantSuite.scala: ########## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql + +import java.io.File + +import scala.util.Random + +import org.apache.spark.sql.test.SharedSparkSession +import org.apache.spark.sql.types.StructType +import org.apache.spark.unsafe.types.VariantVal + +class VariantSuite extends QueryTest with SharedSparkSession { + test("basic tests") { + def verifyResult(df: DataFrame): Unit = { + val result = df.collect() + .map(_.get(0).asInstanceOf[VariantVal].toString) + .sorted + .toSeq + assert(result == (1 until 10).map(id => "1" * id)) Review Comment: Please extracts the expected result as constant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
