tgravescs commented on code in PR #43746:
URL: https://github.com/apache/spark/pull/43746#discussion_r1391420795
##########
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala:
##########
@@ -717,6 +719,15 @@ class CoarseGrainedSchedulerBackend(scheduler:
TaskSchedulerImpl, val rpcEnv: Rp
def sufficientResourcesRegistered(): Boolean = true
+ // When the executor failure tracker collects enough failures, if the
current resources are
+ // insufficient for keep the app running, it will fail the application
directly; otherwise,
+ // it survives this check round.
+ def insufficientResourcesRetained(): Boolean = {
+ totalRegisteredExecutors.get() < maxExecutors * minSurviveRatio
Review Comment:
Exactly so this feature doesn't apply to how many users normally run and
could be confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
