HyukjinKwon commented on code in PR #43784:
URL: https://github.com/apache/spark/pull/43784#discussion_r1391828912
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceManager.scala:
##########
@@ -75,3 +86,136 @@ class DataSourceManager {
dataSourceBuilders.containsKey(normalize(name))
}
}
+
+/**
+ * Data Source V1 wrapper for Python Data Source.
+ */
+object PythonDataSourceCodeGenerator extends Logging {
+ def generateClass(shortName: String): Class[_] = {
+ val ctx = newCodeGenContext()
+
+ val codeBody = s"""
+ private ${classOf[String].getName} source = "$shortName";
Review Comment:
We could do but we should write `java.lang.String` .. that is actually more
and less same I believe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
