pan3793 commented on code in PR #43766:
URL: https://github.com/apache/spark/pull/43766#discussion_r1391927089
##########
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala:
##########
@@ -535,18 +542,78 @@ private[client] class Shim_v2_0 extends Shim with Logging
{
alterPartitionsMethod.invoke(hive, tableName, newParts)
}
- override def dropPartition(
+ override def dropPartitions(
hive: Hive,
dbName: String,
tableName: String,
- part: JList[String],
+ specs: Seq[TablePartitionSpec],
deleteData: Boolean,
+ ignoreIfNotExists: Boolean,
purge: Boolean): Unit = {
val dropOptions = new PartitionDropOptions
dropOptions.deleteData(deleteData)
dropOptions.purgeData(purge)
+ dropOptions.ifExists(ignoreIfNotExists)
recordHiveCall()
Review Comment:
The `recordHiveCall()` must be present before each **HMS RPC call** (you
need to check the underlayer implementation of each Hive.xxx method to figure
out whether it's a RPC call or in-process function invocation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
