LuciferYang commented on PR #43796: URL: https://github.com/apache/spark/pull/43796#issuecomment-1809641168
The cases that have not been fixed in this PR include: 1. Cases that still require additional constructors after modification, such as `YarnShuffleService.AppId`. https://github.com/apache/spark/blob/2cac768fabaa7cad40390b2205dd9c5000011e4c/common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java#L583-L589 In these cases, the modification still requires the retention of constructors, failing to achieve simplification. ```scala @JsonCreator public AppId(@JsonProperty("appId") String appId) { this.appId = appId; } ``` 2. Classes in the hive-thriftserver module. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
