peter-toth commented on PR #43786: URL: https://github.com/apache/spark/pull/43786#issuecomment-1809732959
Actually this is literally the same implementation I came up with internally before I added deterministic mode in https://github.com/apache/spark/pull/42755. But then we reduced the sort argument (`isSortAsc` in this PR) to a simple deterministic flag to keep the change simple. @beliefer, are you referring to the `isSortAsc` argument of the mode function or are you referring to the new `MODE() WITHIN GROUP (ORDER BY col [ASC|DESC])` syntax by "mainstream databases support"? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
