dongjoon-hyun commented on code in PR #36885: URL: https://github.com/apache/spark/pull/36885#discussion_r1393294520
########## core/src/test/scala/org/apache/spark/deploy/history/EventLogTestHelper.scala: ########## Review Comment: As mentioned by Mridul, `JsonProtocol.sparkEventToJson` is private. I don't think Apache Spark needs any PR for this, @msetodev . > It was depending on a previous version of Spark that supported the sparkEventToJson method. Was this method just purely working with a JSON object? You can file an issue on https://github.com/mspnp/spark-monitoring. > Can perhaps someone who is more skilled at Scala than myself please submit a PR to fix this file? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
