LuciferYang commented on code in PR #43796:
URL: https://github.com/apache/spark/pull/43796#discussion_r1394067701
##########
common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/RemoteBlockPushResolverSuite.java:
##########
@@ -1612,19 +1612,8 @@ private void verifyMetrics(
assertEquals(expectedIgnoredBlocksBytes, ignoredBlockBytes.getCount(),
"ignored block bytes");
}
- private static class PushBlock {
- private final int shuffleId;
- private final int shuffleMergeId;
- private final int mapIndex;
- private final int reduceId;
- private final ByteBuffer buffer;
- PushBlock(int shuffleId, int shuffleMergeId, int mapIndex, int reduceId,
ByteBuffer buffer) {
- this.shuffleId = shuffleId;
- this.shuffleMergeId = shuffleMergeId;
- this.mapIndex = mapIndex;
- this.reduceId = reduceId;
- this.buffer = buffer;
- }
+ private record PushBlock(
+ int shuffleId, int shuffleMergeId, int mapIndex, int reduceId,
ByteBuffer buffer) {
Review Comment:
Ok, let me revert this one. The previous commit did not revert it due to
this in test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
