LuciferYang commented on code in PR #43804: URL: https://github.com/apache/spark/pull/43804#discussion_r1394156014
########## docs/sql-error-conditions.md: ########## @@ -2375,9 +2375,3 @@ The operation `<operation>` requires a `<requiredType>`. But `<objectName>` is a The `<functionName>` requires `<expectedNum>` parameters but the actual number is `<actualNum>`. For more details see [WRONG_NUM_ARGS](sql-error-conditions-wrong-num-args-error-class.html) - -### XML_ROW_TAG_MISSING - -[SQLSTATE: 42000](sql-error-conditions-sqlstates.html#class-42-syntax-error-or-access-rule-violation) Review Comment: Yes, this needs to be fixed. Additionally, the ` SQLSTATE table start ` in the `error/README.md` file also needs to be fixed, as there is no definition for the `42KDF` status. @sandip-db , could you quickly fix this issue? Or should we revert this pr first @HyukjinKwon ? GA keeps failing because of this issue. https://github.com/apache/spark/actions/runs/6874376893/job/18695941494 ``` [info] - SQLSTATE invariants *** FAILED *** (30 milliseconds) [info] fx.apply(s) was false 42KDF (SparkThrowableSuite.scala:74) [info] org.scalatest.exceptions.TestFailedException: [info] at org.scalatest.Assertions.newAssertionFailedException(Assertions.scala:472) [info] at org.scalatest.Assertions.newAssertionFailedException$(Assertions.scala:471) [info] at org.scalatest.Assertions$.newAssertionFailedException(Assertions.scala:1231) [info] at org.scalatest.Assertions$AssertionsHelper.macroAssert(Assertions.scala:1295) [info] at org.apache.spark.SparkThrowableSuite.$anonfun$checkCondition$1(SparkThrowableSuite.scala:74) [info] at scala.collection.immutable.List.foreach(List.scala:333) [info] at org.apache.spark.SparkThrowableSuite.checkCondition(SparkThrowableSuite.scala:73) [info] at org.apache.spark.SparkThrowableSuite.$anonfun$new$6(SparkThrowableSuite.scala:138) [info] at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.scala:18) [info] at org.scalatest.enablers.Timed$$anon$1.timeoutAfter(Timed.scala:127) .... [info] - Error classes match with document *** FAILED *** (71 milliseconds) [info] "...gs-error-class.html)[ [info] [info] ### XML_ROW_TAG_MISSING [info] [info] [SQLSTATE: 42KDF](sql-error-conditions-sqlstates.html#class-42-syntax-error-or-access-rule-violation) [info] [info] `<rowTag>` option is required for reading files in XML format.]" did not equal "...gs-error-class.html)[]" The error class document is not up to date. Please regenerate it. (SparkThrowableSuite.scala:346) [info] Analysis: [info] "...gs-error-class.html)[ [info] [info] ### XML_ROW_TAG_MISSING [info] [info] [SQLSTATE: 42KDF](sql-error-conditions-sqlstates.html#class-42-syntax-error-or-access-rule-violation) [info] [info] `<rowTag>` option is required for reading files in XML format.]" -> "...gs-error-class.html)[]" ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
