dongjoon-hyun commented on code in PR #43857:
URL: https://github.com/apache/spark/pull/43857#discussion_r1396642204
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/xml/StaxXmlParser.scala:
##########
@@ -40,16 +40,12 @@ import
org.apache.spark.sql.catalyst.util.LegacyDateFormats.FAST_DATE_FORMAT
import org.apache.spark.sql.catalyst.xml.StaxXmlParser.convertStream
import org.apache.spark.sql.errors.QueryExecutionErrors
import org.apache.spark.sql.internal.SQLConf
-import org.apache.spark.sql.sources.Filter
import org.apache.spark.sql.types._
import org.apache.spark.unsafe.types.UTF8String
class StaxXmlParser(
schema: StructType,
- val options: XmlOptions,
- filters: Seq[Filter] = Seq.empty) extends Logging {
Review Comment:
This constructor seems to be used . Shall we recover this?
```
[error]
/home/runner/work/spark/spark/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/xml/XmlFileFormat.scala:127:9:
too many arguments (found 3, expected 2) for constructor StaxXmlParser:
(schema: org.apache.spark.sql.types.StructType, options:
org.apache.spark.sql.catalyst.xml.XmlOptions):
org.apache.spark.sql.catalyst.xml.StaxXmlParser
[error] actualFilters)
[error] ^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
