xhumanoid commented on code in PR #43844: URL: https://github.com/apache/spark/pull/43844#discussion_r1396950916
########## dev/deps/spark-deps-hadoop-3-hive-2.3: ########## @@ -179,6 +179,8 @@ log4j-1.2-api/2.21.0//log4j-1.2-api-2.21.0.jar log4j-api/2.21.0//log4j-api-2.21.0.jar log4j-core/2.21.0//log4j-core-2.21.0.jar log4j-slf4j2-impl/2.21.0//log4j-slf4j2-impl-2.21.0.jar +logback-classic/1.2.10//logback-classic-1.2.10.jar +logback-core/1.2.10//logback-core-1.2.10.jar Review Comment: logback is runtime dependencies and you can still use log4j with some configuration https://github.com/apache/zookeeper/blob/master/zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md#logging ZooKeeper uses [SLF4J](http://www.slf4j.org/) version 1.7 as its logging infrastructure. By default ZooKeeper is shipped with [LOGBack](http://logback.qos.ch/) as the logging backend, **but you can use any other supported logging framework of your choice.** they don't have any direct usage of logback in their code, except logback.xml configuration file + jars as runtime dependencies -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
