beliefer commented on code in PR #43873:
URL: https://github.com/apache/spark/pull/43873#discussion_r1398020821
##########
core/src/main/scala/org/apache/spark/scheduler/TaskResultGetter.scala:
##########
@@ -32,7 +32,7 @@ import org.apache.spark.util.{LongAccumulator, ThreadUtils,
Utils}
/**
* Runs a thread pool that deserializes and remotely fetches (if necessary)
task results.
*/
-private[spark] class TaskResultGetter(sparkEnv: SparkEnv, scheduler:
TaskSchedulerImpl)
+private[spark] class TaskResultGetter(sparkEnv: SparkEnv, taskScheduler:
TaskSchedulerImpl)
Review Comment:
Traditionally, the `scheduler` looks more minimalist here. No one would
suspect that it is related to a task.
##########
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala:
##########
@@ -49,19 +49,19 @@ import org.apache.spark.util.collection.PercentileHeap
* THREADING: This class is designed to only be called from code with a lock
on the
* TaskScheduler (e.g. its event handlers). It should not be called from other
threads.
*
- * @param sched the TaskSchedulerImpl associated with the
TaskSetManager
+ * @param taskScheduler the TaskSchedulerImpl associated with the
TaskSetManager
* @param taskSet the TaskSet to manage scheduling for
* @param maxTaskFailures if any particular task fails this number of times,
the entire
* task set will be aborted
*/
private[spark] class TaskSetManager(
- sched: TaskSchedulerImpl,
+ taskScheduler: TaskSchedulerImpl,
Review Comment:
I suggest `sched` -> `scheduler`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
