Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/6392#discussion_r31084468
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala ---
@@ -102,12 +102,6 @@ class CrossValidator(override val uid: String) extends
Estimator[CrossValidatorM
/** @group setParam */
def setNumFolds(value: Int): this.type = set(numFolds, value)
- override def validateParams(paramMap: ParamMap): Unit = {
--- End diff --
Sorry, I should have been clearer: CrossValidator still needs to call
validateParams() for each of the estimatorParamMaps. It should copy the
estimator with each paramMap, and then call validateParams for that copy.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
